Skip to content

Add context screen & integrated TOTP support #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 49 commits into from
Sep 9, 2020
Merged

Add context screen & integrated TOTP support #229

merged 49 commits into from
Sep 9, 2020

Conversation

erayd
Copy link
Collaborator

@erayd erayd commented Sep 1, 2020

What

  • Adds a new context screen for displaying pass entries.
  • Adds integrated support for TOTP

Why

  • Because we need an interface for eventually editing passwords in.
  • Adds ability for users to access data from password entries that Browserpass currently ignores.
  • Resolves bitbucket.org issue browserpass-otp#17

erayd and others added 30 commits September 1, 2020 21:41
@erayd
Swap login & password (closes browserpass#214)
cb43222
@erayd
Add UI & hotkey triggers for 'details' action
ea461a0
@erayd
Unmount mithril context before displaying error message
97e48a6
@erayd
Just use mithril for error messages
28622e4
@erayd
Remove unnecessary junk from svg
307c8d3
@erayd
OTP processing
786ae6e
@erayd
Details interface
a58ec69
@erayd
Theming for progress bar colour
b086961
@erayd
Implement OTP options
93d37c8
@erayd
Remove copyOTP setting
fa94cad
@erayd
Field background colours
be969fa
@erayd
Increase margins
fdd35db
@erayd
Disable snack borders
2c7ecab
@erayd
Re-enable borders
55a3113
@erayd
Fix progress bar
9d77c41
@erayd
Fix search markup in entry title
ade1c2b
@erayd
Don't change inline colours on hover
3d79836
@erayd
Remove debug logging
3ffe447
@maximbaz @erayd
Increase spacing, make border less visible, change progressbar color
fc59607
@erayd
Fix label border
fe356a7
@erayd
Fix for bottom spacing when token is visible
7d63219
@erayd
Remove debug logging
4689165
@erayd
We don't support HOTP
97b1ed5
@erayd
Fix otpauth:// URI processing
618db05
@erayd
Progress bar theming
df961c2
@erayd
Fix background
8bc7f38
@erayd
Set cursor
19375d9
@erayd
Remove outline
685b12b
@erayd
Fix border-radius on labels
61a8458
@erayd
Don't use highlighted path
3dfdbc2
@erayd erayd added the feature request New feature request label Sep 1, 2020
@erayd erayd requested a review from maximbaz September 1, 2020 10:27
@erayd erayd self-assigned this Sep 1, 2020
maximbaz
maximbaz reviewed Sep 8, 2020
View reviewed changes
Copy link
Member

@maximbaz maximbaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks extremely good!

@erayd erayd requested a review from maximbaz September 9, 2020 01:39
@erayd erayd mentioned this pull request Sep 9, 2020
Closed
@maximbaz maximbaz mentioned this pull request Sep 9, 2020
Closed
@erayd erayd merged commit 29a7043 into browserpass:master Sep 9, 2020
@maximbaz maximbaz mentioned this pull request Sep 9, 2020
Closed
Preston12321 pushed a commit to Preston12321/browserpass-extension that referenced this pull request Oct 24, 2020
@erayd @Preston12321
Add context screen & integrated TOTP support (browserpass#229)
d10c654
fkneist pushed a commit to fkneist/browserpass-extension that referenced this pull request Feb 12, 2022
@erayd
Add context screen & integrated TOTP support (browserpass#229)
b345263
@r-maerz r-maerz mentioned this pull request Jun 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximbaz maximbaz maximbaz approved these changes

Assignees

@erayd erayd

Labels
feature request New feature request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bitbucket.org issue
2 participants
@erayd @maximbaz