Skip to content

320 part2 address erayds comments #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

patgmiller
Copy link
Contributor

@maximbaz @erayd Here are my changes based on the comments requested/made by @erayd on the original PR for the v3 manifest changes. #366

I also addressed something that was a personal irritation, since I added multiple helper.* files during the refactoring. They are now in a helpers/ directory. Let me know if that unwanted and I'll revert that part.

ll src/helpers
total 64
-rw-r--r--  1 patrick  staff    15K Apr  6 18:52 base.js
-rw-r--r--  1 patrick  staff   1.4K Apr  6 18:01 clipboard.js
-rw-r--r--  1 patrick  staff   1.0K Apr  1 07:54 redraw.js
-rw-r--r--  1 patrick  staff   4.3K Apr  6 18:27 ui.js

Copy link
Member

@maximbaz maximbaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff, thanks! Let's give @erayd a few days to see if he has time to review now, if not we merge and go for a round 3 if necessary.

@patgmiller
Copy link
Contributor Author

sounds great, thanks

@maximbaz maximbaz merged commit 176a418 into browserpass:master May 21, 2025
@patgmiller patgmiller deleted the 320-part2-handle-erayds-mr-comments branch May 30, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants