Add Brave as an install target

[mithodin]

The beta version of brave supports chrome extensions now. Therefore, the install script should support brave. This will need to be updated once extension support gets a stable release.
See issue #294.

[maximbaz]

Thanks a lot @mithodin! We are targeting to release a next major version of browserpass some time soon, which is a complete rewrite and lives in its own repo. I am not planning to make any releases of browserpass from this repo anymore, but I'll make sure to add Brave to the installation script when I get to it :D

Your PR will not be forgotten! But please do update me when a stable Brave gets released.

[maximbaz]

Could you please also find out locations for Darwin? I assume OpenBSD and FreeBSD will use the same path as Linux.

[mithodin]

No problem. I have updated the script accordingly.

[maximbaz]

Awesome, thanks man! I'll make sure to ping you when I get to merging this in v3.

[t56k]

@maximbaz A stable Brave version is now out, but moving the Chromium native messaging host JSON to the Brave folder results in forbidden warnings:

Error: Access to the specified native messaging host is forbidden.

Any way forward before the rewrite?

[maximbaz]

This sounds like you placed json in a wrong folder, or your json contains an invalid path to browserpass executable.

@mithodin have you managed to succeed with stable Brave?

[mithodin]

Works for me with
TARGET_DIR_BRAVE="$HOME/.config/BraveSoftware/Brave-Browser/NativeMessagingHosts"
and the current stable release of brave (0.57.18). One could possibly detect which version of brave is installed and change the path accordingly. Otherwise, I would suggest to change the path so that it works for the stable release as people who use the beta/dev releases should be able to figure things out on their own.

[ewoutp]

I've tried this PR on MacOS and while I'm convinced that the directories are correct, I still get Error: Specified native messaging host not found..

I'm using Version 0.58.18 Chromium: 71.0.3578.98 (Official Build) (64-bit)

[michaelmcandrew]

Just to say, this worked for me on Debian Stretch with Brave installed via https://brave-browser.readthedocs.io/en/latest/installing-brave.html#linux.

I followed the standard instructions but replacing the ./install.sh from the latest release package with the one referenced in this PR.

I tried to add a comment to the following post but couldn't reply due to permissions, I guess: https://community.brave.com/t/browserpass-browser-extension-for-pass-a-unix-password-manager/28931

Thanks for the PR 👍

[chrisswanda]

If using Brave Browser, be sure to:

cp /etc/chromium/native-messaging-hosts/com.dannyvankooten.browserpass.json ~/.config/BraveSoftware/Brave-Browser/NativeMessagingHosts/

This will remove the Native Messaging Hosts error when trying to install. Or this is how I did it.

[maximbaz]

I have included this in Browserpass v3, thanks again for the PR, if you can test now, please share your feedback in #331