Skip to content

Add temporary bash host #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2018
Merged

Add temporary bash host #1

merged 3 commits into from
Apr 11, 2018

Conversation

erayd
Copy link
Collaborator

@erayd erayd commented Apr 9, 2018

Add temporary host (bash script) for testing during development. To be removed once the actual native host is ready.

maximbaz
maximbaz previously approved these changes Apr 9, 2018
Copy link
Member

@maximbaz maximbaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine 🙂 If you want to make this work with browser, a browser will first send 4 bytes in little endian format indicating the length of the message, and only then the actual json.

@erayd
Copy link
Collaborator Author

erayd commented Apr 9, 2018

Huh, I didn't know that. Annoying. I'll add that.

@maximbaz
Copy link
Member

maximbaz commented Apr 9, 2018

https://github.com/chrboe/native.pl is the wrapper tool to test the host app without browser, it basically adds these 4 bytes in the correct format for you.

@erayd erayd merged commit cfc1e38 into browserpass:master Apr 11, 2018
erayd added a commit that referenced this pull request Apr 11, 2018
erayd added a commit that referenced this pull request Apr 11, 2018
@erayd erayd deleted the temp-host branch April 11, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants