Makefile improvements

[maximbaz]

Addressing feedback in #31

[infinisil]

LGTM, if there are any other problems during packaging when I get to it, I'll let you know. Thanks for being considerate <3

[infinisil]

Trying to set BIN to something different I found something that needs changing in the Makefile:

browserpass-native/Makefile

Lines 17 to 18 in 8411954

	browserpass: *.go **/*.go
	go build -ldflags $(GO_LDFLAGS) -gcflags $(GO_GCFLAGS) -asmflags $(GO_ASMFLAGS) -o $@

The -o $@ always makes the binary name be browserpass, should be changed to $(BIN) (also in the build commands following that one)

[maximbaz]

Those commands intentionally produce binaries with different names, because I need all of them to make a Github release :)

I thought for BIN as purely a way to configure install target, i.e. if you downloaded linux release from Github, the binary would be called browserpass-linux64, and thus to install you would run make BIN=browserpass-linux64 install.

Maybe simply do make browserpass followed by mv browserpass <newName>, and then make BIN=<newName> install, would that work for you?

[infinisil]

Hmm I see, was trying to avoid having to manually rename the binary, but yeah that works.

[maximbaz]

It's temporary, I guess a month from now you'll be able to cleanup the build commands and return to browserpass as a binary name 😉

[infinisil]

Almost done with packaging this for Nix/NixOS. Two suggestion I have regarding the linking targets in the Makefile:

• Using these currently results in no output. Adding -v to ln would make it output what is being linked
• If the path to be linked isn't valid, you end up with an invalid symlink without the user noticing. I suggest adding an error message in that case.

[infinisil]

Oh and I just saw that you're using the host files where the policies files are supposed to be:

browserpass-native/Makefile

Line 217 in 67a63f0

ln -sf "$(LIB_DIR)/browserpass/hosts/chromium/$(APP_ID).json" "/etc/chromium/policies/managed/" \