Skip to content

Unknown jail config property handling #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2018

Conversation

gronke
Copy link
Member

@gronke gronke commented Jul 19, 2018

Listing jails with resource limit properties set failed loading. With this change the resource limit properties are included in jail.config.all_properties. Additionally loading jails with unknown properties raises a warnings when loading jails that already have invalid properties in their configuration.

@gronke gronke added the bug label Jul 19, 2018
@gronke gronke force-pushed the fix/unknown-jail-config-property branch from ac1e014 to 781956d Compare July 19, 2018 20:17
@gronke gronke merged commit 0800c4c into master Jul 19, 2018
@gronke gronke deleted the fix/unknown-jail-config-property branch July 19, 2018 22:39
@igalic
Copy link
Collaborator

igalic commented Jul 20, 2018

does this give us a name-space where we can store user-defined properties? (i.e.: user.*) or annotations / labels (à la Kubernetes)?

@gronke
Copy link
Member Author

gronke commented Jul 20, 2018

No, there is currently no such feature. I'd like to wait for #426 to be merged because it brings nested configuration variables in config.json. @igalic feel free to open an issue requesting this feature 👍

@igalic
Copy link
Collaborator

igalic commented Jul 20, 2018

that is, in part, #413
but i think we could be more explicit here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants