Skip to content

New method "getAvailableStatusesForManualMarking()"#28

Merged
ndeet merged 2 commits intobtcpayserver:masterfrom
storefront-bvba:available-statuses
Oct 26, 2021
Merged

New method "getAvailableStatusesForManualMarking()"#28
ndeet merged 2 commits intobtcpayserver:masterfrom
storefront-bvba:available-statuses

Conversation

@woutersamaey
Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread src/Result/Invoice.php
@woutersamaey
Copy link
Copy Markdown
Collaborator Author

woutersamaey commented Oct 26, 2021

There are 2 things we can do here:

  • We simply merge this PR
  • Or, I can check the version first and if it's <= 1.2.4 this call throws an exception. If > 1.2.4 this call does what it's coded.
    The extra data will be added on the next release. I'm not sure about the version number, but my guess is it will be 1.2.5 unless they jump immediately to 1.3.0

The version check etc would be overhead and I'm not sure if this is something we want.
I can add this info as a comment on the method though...

If you're on an older version it will throw an exception anyway. Just not a pretty one.

@woutersamaey
Copy link
Copy Markdown
Collaborator Author

I improved the comment a bit, but still waiting on the next version number so I can fill it in.

@ndeet
Copy link
Copy Markdown
Collaborator

ndeet commented Oct 26, 2021

Yeah let's merge if it is coming anyway. Imo no need to do any check as everybody is encouraged to run latest versions and if there is a problem suggesting "try upgrade to latest version" will fix it. So I agree with you, let's merge it.

@ndeet ndeet merged commit 70f4cf3 into btcpayserver:master Oct 26, 2021
@woutersamaey woutersamaey deleted the available-statuses branch October 27, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants