fix(ui): use variation name as label in evaluation chart for YAML/JSON type#2573
Open
steveninhle wants to merge 1 commit into
Open
fix(ui): use variation name as label in evaluation chart for YAML/JSON type#2573steveninhle wants to merge 1 commit into
steveninhle wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the feature-flag evaluation chart legend to display human-readable variation labels for JSON/YAML (and other) variation types by preferring a variation’s name and falling back to value, matching the behavior already used in the evaluation table.
Changes:
- Resolve each chart legend label via
variation.name || variation.value(with fallback to"default value"for the default bucket). - Refactor label resolution to avoid repeating the
findcall inline and improve readability.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
variation label, making it unreadable for those variation types
variation.name || variation.value,which prefers the human-readable name when set and falls back to value
otherwise
uses the same
name || valuefallback pattern