feat: add support for react 19#5
Merged
Merged
Conversation
07aca4c to
47b0236
Compare
There was a problem hiding this comment.
Pull request overview
This pull request adds React 19 support to the react-native-client-sdk while maintaining React 18 compatibility. The changes introduce a matrix testing strategy in CI workflows to test both React versions, create separate demo projects for each React version, update peer dependencies to support both versions, and clarify documentation about supported versions and installation requirements.
Key changes:
- CI workflows now test both React 18 and React 19 through matrix strategies
- New demo projects:
demo/expo_react_19anddemo/expo_react_18(previouslyexample) - Peer dependencies updated to support React 18.2.0 through 19.x
- SDK dependencies moved to devDependencies and added as peer dependencies
Reviewed changes
Copilot reviewed 69 out of 182 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated scripts for separate React version testing, moved SDK dependencies to devDependencies, added peer dependency requirements, changed workspace paths |
| yarn.lock | Added React 19, Expo 54, and related dependency versions while maintaining React 18 dependencies |
| e2e/react_versions/*.yml | New E2E test files to verify React version-specific functionality |
| demo/expo_react_19/* | Complete new demo project for React 19 testing with Expo 54 and React Native 0.81 |
Files not reviewed (1)
- demo/expo_react_19/ios/example.xcworkspace/contents.xcworkspacedata: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@cre8ivejp please help me to take a look |
2deb11b to
eb8b5ca
Compare
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project to add support for React 19 in both the codebase and CI workflows, while also clarifying peer dependency requirements and supported versions in the documentation. The changes ensure that end-to-end (E2E) tests are run against both React 18 and React 19 environments for iOS and Android, and the documentation now reflects the expanded compatibility and installation steps.
CI Workflow Updates for React 19 Support:
.github/workflows/e2e.yml) now runs tests for both React 18 and React 19 by introducing a matrix strategy for thereact-versionparameter in both iOS and Android jobs. This includes environment setup, dependency caching, and separate build/test steps for each React version. [1] [2] [3] [4] [5] [6]feat/init-sdktofeat/support-react-19to align with the new feature branch naming..github/workflows/build.yml) was updated to build and export bothdemo/expo_react_18anddemo/expo_react_19projects for the web platform.Documentation Improvements:
README.mdnow lists@bucketeer/js-client-sdkand@bucketeer/react-client-sdkas required peer dependencies and clarifies installation instructions.E2e tests passed
https://github.com/bucketeer-io/react-native-client-sdk/actions/runs/19662569026