Add nanopb plugin#1234
Conversation
pkwarren
left a comment
There was a problem hiding this comment.
Looks great - just a few suggestions on the Dockerfile.
Are you talking about using this plugin as a Generated SDK? If so you are correct and there isn't support for C programs today. This plugin would be available initially only as a Remote Plugin. If you wish for the plugin itself to include additional C files in the output, it would need to ship them in the nanopg generator plugin itself using the |
Co-authored-by: Philip K. Warren <pkwarren@users.noreply.github.com>
That's fine then, I just wanted to make sure I would add it as well in case it's already supported by nanopb.
Makes sense, that's something that would have to be implemented in nanopb itself then. I went ahead and applied your suggestions, updated the PR, and marked it as ready. |
|
lgtm, thanks for taking the time to contribute 🥳. |
|
Thanks guys! |
|
Awesome, the plugin has been published via the automation in this repository to https://buf.build/community/nanopb Took it for a spin # buf.gen.yaml
version: v1
managed:
enabled: true
plugins:
- plugin: buf.build/community/nanopb:v0.4.8
out: genAnd then generated some code output |
Closes #683
This PR is marked as a draft because of the following open points: