Improve TypeRegistry #113
Merged
Improve TypeRegistry #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the behavior of adding types to a TypeRegistry: A common use case for the TypeRegistry is serializing google.protobuf.Any. That typical involves adding the desired types, and the types they use. We can trivially automate the second part of this, making the TypeRegistry more convenient to use. This also makes the method add() public, and replaces the static methods fromIterable() and fromTypes() with a single from() that takes all supported types as an input, not just message types.
Merged
timostamm
added a commit
to connectrpc/connect-es
that referenced
this pull request
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior of adding types to a TypeRegistry: A common use case for the TypeRegistry is serializing google.protobuf.Any. That typical involves adding the desired types, and the types they use. We can trivially automate the second part of this, making the TypeRegistry more convenient to use.
This also makes the method add() public, and replaces the static methods fromIterable() and fromTypes() with a single from() that takes all supported types as an input, not just message types.