Remove circular dependencies #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
paul-sachs
commented
Jun 15, 2022
paul-sachs
commented
- Modified generator to not create cycles
- Add lint rule
- Fix linting imports
- Remove lint rule to restrict duplicate imports
paul-sachs
commented
Jun 15, 2022
Comment on lines
+40
to
+59
| if bootstrapWKT { | ||
| return &Runtime{ | ||
| ProtoN: symbolPool.new(syntax.String(), fmt.Sprintf("./%s.js", syntax.String())), | ||
| Message: symbolPool.new("Message", "./message.js"), | ||
| PartialMessage: symbolPool.new("PartialMessage", "./message.js").ToTypeOnly(), | ||
| PlainMessage: symbolPool.new("PlainMessage", "./message.js").ToTypeOnly(), | ||
| FieldList: symbolPool.new("FieldList", "./field-list.js").ToTypeOnly(), | ||
| MessageType: symbolPool.new("MessageType", "./message-type.js").ToTypeOnly(), | ||
| BinaryReadOptions: symbolPool.new("BinaryReadOptions", "./binary-format.js").ToTypeOnly(), | ||
| BinaryWriteOptions: symbolPool.new("BinaryWriteOptions", "./binary-format.js").ToTypeOnly(), | ||
| JsonReadOptions: symbolPool.new("JsonReadOptions", "./json-format.js").ToTypeOnly(), | ||
| JsonWriteOptions: symbolPool.new("JsonWriteOptions", "./json-format.js").ToTypeOnly(), | ||
| JsonValue: symbolPool.new("JsonValue", "./json-format.js").ToTypeOnly(), | ||
| JsonObject: symbolPool.new("JsonObject", "./json-format.js").ToTypeOnly(), | ||
| ProtoInt64: symbolPool.new("protoInt64", "./proto-int64.js"), | ||
| ScalarType: symbolPool.new("ScalarType", "./field.js"), | ||
| MethodKind: symbolPool.new("MethodKind", "./service-type.js"), | ||
| MethodIdempotency: symbolPool.new("MethodIdempotency", "./service-type.js"), | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
Couldn't think of a better way to handle this without doing some significant rearchitecting. I think it's sufficient, if a little frail.
timostamm
approved these changes
Jun 15, 2022
Member
There was a problem hiding this comment.
I can't think of a simple alternative either. The tight coupling to the internal file layout of the runtime library is not ideal, but as long as we keep releasing generator and library in sync, any possible mismatch we introduce will be caught by CI - the tests deliberately run in a separate package to catch things like that.
Thanks for the fix, this is great! We can remove index-runtime.ts and some other bits now, I'll open a follow-up.
timostamm
added a commit
that referenced
this pull request
Jun 15, 2022
After #119, we can revert the introduction of index-runtime.ts, and don't need runtimeImportPathBootstrapWKT anymore.
Merged
paul-sachs
deleted the
psachs/tcn-115-avoid-circular-imports-in-the-well-known
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.