Remove bigint literal in google.protobuf.Duration, clarify required target environment #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could be es2016, but we use Object.entries in @bufbuild/protobuf.
paul-sachs
approved these changes
Jun 17, 2022
timostamm
added a commit
to connectrpc/connect-es
that referenced
this pull request
Jun 21, 2022
Similar to bufbuild/protobuf-es#122, we were still using target es2020, but should be fine with es2017.
This was referenced Jun 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now compile @bufbuild/protobuf to es2017 instead of es2020. It could be es2016 if we did not use Object.entries. es2020 is only required for the BigInt constructor function and for BigInt literals.
protobuf-test compiles to es2017 now as well, to ensure consumers of @bufbuild/protobuf do not have any issues.
One use of a BigInt literal was left in google.protobuf.Duration, which would have blocked es2017 users of using it. It is removed by the first commit.