Skip to content

Conversation

@timostamm
Copy link
Member

We didn't mark our package as free from side effects. This shaves off a third of our bundle size in a simple use case.

Code size is now in the expected range - best in class:

code generator bundle size minified compressed
protobuf-es 72,457 b 35,936 b 9,393 b
ts-proto 73,318 b 36,033 b 9,613 b
protobuf-ts 97,516 b 45,850 b 11,452 b
google-protobuf 368,034 b 270,748 b 43,704 b

We didn't mark our package as free from side effects.
@timostamm timostamm merged commit adeff25 into main May 6, 2022
@timostamm timostamm deleted the tstamm/no-side-effects branch May 6, 2022 14:48
@timostamm timostamm mentioned this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants