Skip to content

[Android-3721] Copy design module from publish to samples app #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hackertronix
Copy link
Contributor

@hackertronix hackertronix commented Jul 27, 2020

👆️

This is copied over without any changes from the publish repo

Jira Ticket

https://buffer.atlassian.net/browse/ANDROID-3721

@hackertronix hackertronix requested a review from hitherejoe July 27, 2020 08:41
@hackertronix hackertronix force-pushed the task/copy-design-module-to-samples branch from 415dac6 to 58dace1 Compare July 27, 2020 08:45
@hackertronix
Copy link
Contributor Author

@hitherejoe Would you be able to look at this? :)

}
}
dependencies {
api project(':app')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come design needs to know about app?

Copy link
Collaborator

@hitherejoe hitherejoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be great for sharing the theme around! I left a comment, I'm not sure why design depends on the app module

Also, the App module is what we release as the library, so with this change design will never actually be available to users of the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants