Skip to content

Don't allow insecure proxy setting #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kattrali merged 3 commits into from
Jul 18, 2016
Merged

Don't allow insecure proxy setting #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3eb53b2
Don't allow insecure proxy setting
GrahamCampbell Jul 18, 2016
927e7ec
Don't allow through insecure http proxy config
GrahamCampbell Jul 18, 2016
e9c64a4
If not cli
GrahamCampbell Jul 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/bugsnag.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@
*/

'proxy' => array_filter([
'http' => env('HTTP_PROXY'),
'https' => env('HTTPS_PROXY'),

@GrahamCampbell GrahamCampbell Jul 18, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the option from the default config file.

@GrahamCampbell GrahamCampbell Jul 19, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored in #145 since it's still safe for cli, so no real reason to remove it.

'no' => explode(',', str_replace(' ', '', env('NO_PROXY', ''))) ?: null,
]),
Expand Down
4 changes: 4 additions & 0 deletions src/BugsnagServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ public function register()
$options = ['base_uri' => isset($config['endpoint']) ? $config['endpoint'] : Client::ENDPOINT];

if (isset($config['proxy']) && $config['proxy']) {
if (isset($config['proxy']['http']) && php_sapi_name() != 'cli') {

@GrahamCampbell GrahamCampbell Jul 18, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't allow the option through if we're on a vulnerable system because it's likely it was set by an env variable, particularly if from an old config file.

unset($config['proxy']['http']);
}

$options['proxy'] = $config['proxy'];
}

Expand Down