Attach handlePointerUp to ownerDocument body #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| dispatchPointerEvent("pointerup", leftElement); | ||
| }); | ||
|
|
||
| expect(separateWindowDocument.body.addEventListener).toHaveBeenCalledWith("pointerup", expect.anything(), expect.anything()); |
Contributor
Author
There was a problem hiding this comment.
This checks if addEventListener is called to add the handlePointerUp to the body element. I am looking into a stricter matcher than expect.anything for checking the callback being added
Owner
|
Published in [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes which element the handlePointerUp event handler is added to, it now adds the event handler to the body element of each owner docment where a panelResizeHandle is rendered. This accounts for use cases where the panelResizeHandle is rendered in a document that is in a child window.
This PR also adds a test for checking which document body the event handler is added to, which demonstrates a usecase where PanelResizeHandles are rendered to a separate document.
addresses #468