Skip to content

Remove localtunnel integration #36

@naholyr

Description

@naholyr

localtunnel has not been very reliable during tests, so it may be a good idea to just remove it. However, it brings some issues:

  • Client-side must be modified when using a tunnel, so we have to add a test in client to drop websocket support when using such tunnel:
    if (document.location.hostname.match(/(\.localtunnel\.me|\.ngrok\.io)$/)) {
    // Websocket transports screws the whole thing when tunnelling through localtunnel
    socketOptions = { transports: ['polling'] }
    }
    • Solution would be to just drop websocket support when hostname is not an IP address?
    • Maybe upgrading to socket.io 2.x would fix it
  • Tunnel's hostname is an interesting thing to store so we can reuse it when restarting, in our localtunnel integration we just let it be randomly generated first time then store it in a file to reuse the same one on next starts: user doesn't have to choose a hostname, but does not lose the permanent url
    • I think we can just drop this and have user use his tunnel tool and choose himself the hostname if he wants it to be permanent, useless feature imo

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions