Skip to content

PermissionsExt::mode masks off the format bits #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sunfishcode opened this issue Jun 4, 2022 · 0 comments · Fixed by #256
Closed

PermissionsExt::mode masks off the format bits #249

sunfishcode opened this issue Jun 4, 2022 · 0 comments · Fixed by #256

Comments

@sunfishcode
Copy link
Member

As reported here, cap-std's PermissionExt::mode returns a mode value with the format bits masked out, while std's PermissionsExt::mode returns the raw mode value. It's cap-std'd intention to match std, so it should remove the masking.
@sunfishcode sunfishcode mentioned this issue Jun 4, 2022
Merged
@sunfishcode sunfishcode changed the title PermissionsExt::mode masks off the format bigs PermissionsExt::mode masks off the format bits Jun 4, 2022
sunfishcode added a commit that referenced this issue Jun 21, 2022
@sunfishcode
Don't apply a mask on the flags in PermissionsExt.
fe33af7 
For consistency with std, don't apply a mask to the flags bits in
`PermissionsExt`.

Fixes #249.
@sunfishcode sunfishcode mentioned this issue Jun 21, 2022
Merged
sunfishcode added a commit that referenced this issue Jun 23, 2022
@sunfishcode
Don't apply a mask on the flags in PermissionsExt.
e7e906c 
For consistency with std, don't apply a mask to the flags bits in
`PermissionsExt`.

Fixes #249.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't apply a mask on the flags in PermissionsExt. bytecodealliance/cap-std
1 participant
@sunfishcode