Annotations

[yoshuawuyts]

Depends on #371. Adds support for component-native annotations. I wasn't quite sure what to put in the "language field" for the top-level component, but I figured "Rust" would be a good fit. Thanks!

Before

$ wasm-tools metadata show component.wasm

╭──────────────┬─────────────────────────╮
│ KIND         ┆ VALUE                   │
╞══════════════╪═════════════════════════╡
│ kind         ┆ component               │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ name         ┆ <unknown>               │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ range        ┆ 0x0..0x2c9f9b           │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ processed-by ┆ wit-component [0.216.0] │
╰──────────────┴─────────────────────────╯

After

$ wasm-tools metadata show component.wasm
╭──────────────┬───────────────────────────────────────────────────╮
│ KIND         ┆ VALUE                                             │
╞══════════════╪═══════════════════════════════════════════════════╡
│ kind         ┆ component                                         │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ name         ┆ rust-wasi-hello                                   │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ range        ┆ 0x0..0x5d35f1                                     │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ author       ┆ Yosh Wuyts <[email protected]>                    │                                                
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ version      ┆ 0.0.0                                             │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ processed-by ┆ wit-component [0.225.0]                           │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ processed-by ┆ cargo-component [0.20.0-dev (7057351 2025-02-17)] │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ language     ┆ Rust                                              │
╰──────────────┴───────────────────────────────────────────────────╯

[yoshuawuyts]

Oh shoot, as mentioned in bytecodealliance/wasm-pkg-tools#150 (comment) we should not create authors in the producers until bytecodealliance/wasm-tools#2054 has landed. Making a note here so I don't forget.

[yoshuawuyts]

fixed the author bits of the PR. Once #371 has been merged this should be good to go now!

[yoshuawuyts]

#371 has been merged; this is now ready for review

[yoshuawuyts]

Tests seem to be failing because Rust 1.58 has shipped, warning that unsafe fn (unsafe to call) no longer implies unsafe {} (may call unsafe) in the generated wit-bindgen bindings.

[yoshuawuyts]

bytecodealliance/wit-bindgen#1183 should fix this I believe.

[pchickey]

Just needs a rebase on main now

[yoshuawuyts]

rebased; now just waiting on CI to pass

[yoshuawuyts]

I don't have merge rights on this, but I think it's ready to be merged!