-
Notifications
You must be signed in to change notification settings - Fork 195
Update linux-raw-sys to 0.6 #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yes, this is unfortunately semver breaking. If there's a specific feature you need in linux-raw-sys 0.6, we can backport or add compatible definitions it to 0.4. |
I'm personally interested in this for the futex support in io_uring |
0.38.x releases are now being done in a dedicated 0.38 branch, so The CI failure looks like rustix's |
@oherrala Do you plan on updating this to fix CI ? If not I'd be happy to take over |
c2963af
to
d6b6435
Compare
The CI failure here looks due to changes in the layout of |
12292b7
to
725c0e5
Compare
This is caused by the |
Starting with |
725c0e5
to
3be7637
Compare
Rebased my changes on top of ef39477. Let's see if the tests pass now. |
3be7637
to
d433f20
Compare
We hit on the listxattr call exposing |
See bytecodealliance/rustix#1061 (comment) Basically current rustix 0.38 sometimes may expose the element type as a signed or unsigned variant, depending on the version of linux-raw-sys and rustix feature flags. Add a cast to work around this; if we cared to drop the unsafe we could use the zerocopy crate. Signed-off-by: Colin Walters <[email protected]>
See bytecodealliance/rustix#1061 (comment) Basically current rustix 0.38 sometimes may expose the element type as a signed or unsigned variant, depending on the version of linux-raw-sys and rustix feature flags. Add a cast to work around this; if we cared to drop the unsafe we could use the zerocopy crate. Signed-off-by: Colin Walters <[email protected]>
This field is introduced in kernel version 6.8.
d433f20
to
cdf4ab0
Compare
Thanks! |
This required changing fields of some structs under
io_uring
thus probably braking semantic versioning.