This repository was archived by the owner on Sep 8, 2025. It is now read-only.
add test coverage for issue 209 #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dicej
added a commit
that referenced
this pull request
Jun 12, 2025
This commit doesn't include a test case, but #212 covers it, and we have another in the `miri-fiber` branch which will make it to `main` eventually. Fixes #45 Signed-off-by: Joel Dice <[email protected]>
This is a follow up to my earlier fix for #209, adding a test (courtesy of Luke) to help ensure it doesn't regress. Co-authored-by: Luke Wagner <[email protected]> Signed-off-by: Joel Dice <[email protected]>
dicej
force-pushed
the
dicej/test-for-209
branch
from
ecb7180 to
f50cf89
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to my earlier fix for #209, adding a test (courtesy of Luke) to help ensure it doesn't regress.