Skip to content

lib-socket: make getaddrinfo return EAI_ values #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

lib-socket: make getaddrinfo return EAI_ values #4498

merged 1 commit into from
Jul 21, 2025

Conversation

yamt
Copy link
Collaborator

@yamt yamt commented Jul 17, 2025

cf. #4464

lum1n0us
lum1n0us reviewed Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to disrupt the recently modified ABIs that only return 0 and -1. Is it worthwhile?

@lum1n0us lum1n0us added the breaking-change Determine if this PR introduces breaking changes. It will be used by scripts to classify PRs. label Jul 17, 2025
@yamt
Copy link
Collaborator Author

yamt commented Jul 17, 2025

It seems to disrupt the recently modified ABIs that only return 0 and -1. Is it worthwhile?

#4476 is about traditional socket system calls like setsockopt.

this PR is about getaddrinfo, which is relatively new and has a different convention.

loganek
loganek approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@loganek loganek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lum1n0us lum1n0us merged commit a780ffd into bytecodealliance:main Jul 21, 2025
454 checks passed
@yamt yamt mentioned this pull request Aug 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loganek loganek loganek approved these changes

@lum1n0us lum1n0us lum1n0us approved these changes

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@TianlongLiang TianlongLiang Awaiting requested review from TianlongLiang TianlongLiang is a code owner

@wenyongh wenyongh Awaiting requested review from wenyongh wenyongh is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

Assignees
No one assigned
Labels
breaking-change Determine if this PR introduces breaking changes. It will be used by scripts to classify PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yamt @loganek @lum1n0us