Skip to content

Commit ab53612

Browse files
katelyn martinalexcrichton
andauthored
update WASI submodule (#3025)
* wasi-common: update wasi submodule This updates the WASI submodule, pulling in changes to the witx crate, now that there is a 0.9.1 version including some bug fixes. See WebAssembly/WASI#434 for more information. * wiggle: update witx dependencies * publish: verify and vendor witx-cli * adjust root workspace members This commit removes some items from the root manifest's workspace members array, and adds `witx-cli` to the root `workspace.exclude` array. The motivation for this stems from a cargo bug described in rust-lang/cargo#6745: `workspace.exclude` does not work if it is nested under a `workspace.members` path. See WebAssembly/WASI#438 for the underlying change to the WASI submodule which reorganized the `witx-cli` crate, and WebAssembly/WASI#398 for the original PR introducing `witx-cli`. See [this comment](#3025 (comment)) for more details about the compilation errors, and failed alternative approaches that necessitated this change. N.B. This is not a functional change, these crates are still implicitly workspace members as transitive dependencies, but this will allow us to side-step the aforementioned cargo bug. Co-Authored-By: Alex Crichton <[email protected]> Co-authored-by: Alex Crichton <[email protected]>
1 parent 652f21e commit ab53612

File tree

7 files changed

+10
-25
lines changed

7 files changed

+10
-25
lines changed

Cargo.lock

Lines changed: 4 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,19 +73,13 @@ members = [
7373
"cranelift",
7474
"crates/bench-api",
7575
"crates/c-api",
76-
"crates/fuzzing",
7776
"crates/misc/run-examples",
78-
"crates/wiggle",
79-
"crates/wiggle/generate",
80-
"crates/wiggle/macro",
81-
"crates/wasi-common",
82-
"crates/wasi-common/cap-std-sync",
83-
"crates/wasi-common/tokio",
8477
"examples/fib-debug/wasm",
8578
"examples/wasi/wasm",
8679
"examples/tokio/wasm",
8780
"fuzz",
8881
]
82+
exclude = ['crates/wasi-common/WASI/tools/witx-cli']
8983

9084
[features]
9185
default = ["jitdump", "wasmtime/wat", "wasmtime/parallel-compilation", "wasi-nn"]

crates/wasi-common/WASI

Submodule WASI updated 64 files

crates/wiggle/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ include = ["src/**/*", "README.md", "LICENSE"]
1212

1313
[dependencies]
1414
thiserror = "1"
15-
witx = { path = "../wasi-common/WASI/tools/witx", version = "0.9.0", optional = true }
15+
witx = { path = "../wasi-common/WASI/tools/witx", version = "0.9.1", optional = true }
1616
wiggle-macro = { path = "macro", version = "0.28.0" }
1717
tracing = "0.1.15"
1818
bitflags = "1.2"

crates/wiggle/generate/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ include = ["src/**/*", "README.md", "LICENSE"]
1414
[lib]
1515

1616
[dependencies]
17-
witx = { version = "0.9.0", path = "../../wasi-common/WASI/tools/witx" }
17+
witx = { version = "0.9.1", path = "../../wasi-common/WASI/tools/witx" }
1818
quote = "1.0"
1919
proc-macro2 = "1.0"
2020
heck = "0.3"

crates/wiggle/macro/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ doctest = false
2222

2323
[dependencies]
2424
wiggle-generate = { path = "../generate", version = "0.28.0" }
25-
witx = { version = "0.9.0", path = "../../wasi-common/WASI/tools/witx" }
25+
witx = { version = "0.9.1", path = "../../wasi-common/WASI/tools/witx" }
2626
quote = "1.0"
2727
syn = { version = "1.0", features = ["full"] }
2828
proc-macro2 = "1.0"

scripts/publish.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ fn read_crate(manifest: &Path) -> Crate {
176176
} else {
177177
version.clone()
178178
};
179-
if ["witx", "wasi-crypto"].contains(&&name[..]) {
179+
if ["witx", "witx-cli", "wasi-crypto"].contains(&&name[..]) {
180180
publish = false;
181181
}
182182
Crate {

0 commit comments

Comments
 (0)