Remove witx
workspace
#438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fell out of this comment in bytecodealliance/wasmtime#3025.
In short, the workspace added in #398 causes some surprising headaches when attempting to use this in projects with a certain shape of nested cargo workspace. As I understand it, that is an instance of the bug described in rust-lang/cargo#6745, wherein
excludes
do not behave properly when excluding a subdirectory within a workspace member.So, in order to make
witx
andwitx-cli
easier to incorporate in such projects, we hoistwitx-cli
into a sibling crate attools/witx-cli
rather thantools/witx/cli
.