Skip to content

Simplify ssa builder #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 20, 2020
Merged

Simplify ssa builder #1340

merged 4 commits into from
Mar 20, 2020

Conversation

Y-Nak
Copy link
Contributor

@Y-Nak Y-Nak commented Mar 17, 2020 •
edited
Loading

Update info

  • Remove redundant structs/fields/methods/functions from cranelift/frontend/src/ssa.rs
  • Adapt FunctionBuilder to updated SSABuilder
  • Update docs
  • Update tests
  • This PR contains test cases, if meaningful.
  • A reviewer from the core maintainer team has been assigned for this PR.
    r? @bnjbvr @eqrion

@bjorn3
Copy link
Contributor

bjorn3 commented Mar 17, 2020

Could you please add Fixes #1259 to the PR description? That way github will automatically close the issue when this PR is merged.

sunfishcode
sunfishcode approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! The fact that the SSA Builder was already maintaining its own basic-block-like structure was one of the things pointing towards switching to basic blocks, so it's fun to see the simplifications being realized :-).

@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Mar 17, 2020
@github-actions

This comment has been minimized.

Sign in to view
abrown added a commit to abrown/wasmtime that referenced this pull request Mar 18, 2020
@abrown @yurydelendik
Fix remaining clippy warnings (bytecodealliance#1340)
e1d513a 
* clippy: allow complex encoding function

* clippy: remove unnecessary main() function in doctest

* clippy: remove redundant `Type` suffix on LaneType enum variants

* clippy: ignore incorrect debug_assert_with_mut_call warning

* clippy: fix FDE clippy warnings
@sunfishcode
Copy link
Member

The CI failure here is likely due to running out of disk space. Would you mind rebasing this on master, which has several fixes to reduce the size of the build directory?

@Y-Nak Y-Nak force-pushed the simplify-ssa-builder branch from 413dfb2 to cd29c80 Compare March 19, 2020 01:30
@sunfishcode
Copy link
Member

Thanks!

@sunfishcode sunfishcode merged commit bcddce5 into bytecodealliance:master Mar 20, 2020
@Y-Nak Y-Nak deleted the simplify-ssa-builder branch March 21, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunfishcode sunfishcode sunfishcode approved these changes

Assignees
No one assigned
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cranelift] Simplify SSABuilder with basic block
3 participants
@Y-Nak @bjorn3 @sunfishcode