Add examples of linking and WASI #1369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
approved these changes
Mar 20, 2020
examples/linking.c
Outdated
| wasm_byte_vec_t error; | ||
| if (wasmtime_wat2wasm(engine, &wat, bytes, &error) == 0) { | ||
| fprintf(stderr, "failed to parse wat %.*s\n", (int) error.size, error.data); | ||
| exit(0); |
There was a problem hiding this comment.
This should exit with a non-zero status.
This commit adds two example programs, one for linking two modules together and one for instantiating WASI. The linkage example additionally uses WASI to get some meaningful output at this time. cc bytecodealliance#1272
alexcrichton
force-pushed
the
inter-module-examples
branch
from
55b6820 to
be304e6
Compare
|
Good idea! I've added all the examples as pages to the book, @sunfishcode want to take another look? |
github-actions
bot
added
the
wasmtime:docs
sunfishcode
reviewed
Mar 20, 2020
docs/embed-rust.md
Outdated
| @@ -3,7 +3,7 @@ | |||
| This document shows an example of how to embed Wasmtime using the [Rust | |||
| API][apidoc] to execute a simple wasm program. Be sure to also check out the | |||
| [full API documentation][apidoc] for a full listing of what the [`wasmtime` | |||
| crate][crate] has to offer. | |||
| crate][wasmtime] has to offer. | |||
There was a problem hiding this comment.
Would it make sense to mention the examples here too, just to make sure people who skip ahead to the embedding chapter don't miss the examples that go along with it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two example programs, one for linking two modules
together and one for instantiating WASI. The linkage example
additionally uses WASI to get some meaningful output at this time.
cc #1272