Skip to content

filecheck: Use std::fs::read_to_string instead of hand-rolled copy #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2020
Merged

filecheck: Use std::fs::read_to_string instead of hand-rolled copy #1627

merged 1 commit into from
Apr 29, 2020

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Apr 29, 2020

No description provided.

@fitzgen fitzgen requested a review from sunfishcode April 29, 2020 00:08
sunfishcode
sunfishcode approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :-).

@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Apr 29, 2020
@github-actions
Copy link

Subscribe to Label Action

cc @bnjbvr

This issue or pull request has been labeled: "cranelift"

Thus the following users have been cc'd because of the following labels:

  • bnjbvr: cranelift

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@sunfishcode sunfishcode merged commit c9b27b4 into bytecodealliance:master Apr 29, 2020
@fitzgen fitzgen deleted the read-to-string branch April 29, 2020 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunfishcode sunfishcode sunfishcode approved these changes

Assignees
No one assigned
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fitzgen @sunfishcode