update future/stream ABIs and names
#1315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates `wit-bindgen-rt` etc. to use (some of) the new ABI defined in WebAssembly/component-model#524. It covers everything in that PR _except_ the lifting and lowering changes to `future.{read,write}`, which we decided are more trouble than they're worth. I've tested this end-to-end with `wasip3-prototyping` and will soon post a corresponding PR there. Finally, `rustfmt` was complaining about using `gen` as a field name, so I took this opportunity to address that. Signed-off-by: Joel Dice <[email protected]> fix rust codegen build errors Signed-off-by: Joel Dice <[email protected]> snapshot Signed-off-by: Joel Dice <[email protected]>
alexcrichton
approved these changes
Jun 9, 2025
| let mut gen = self.interface(resolve, true, Some(&wasm_import_module)); | ||
| gen.interface = Some((id, name)); | ||
| gen.define_interface_types(id); | ||
| let mut r#gen = self.interface(resolve, true, Some(&wasm_import_module)); |
Member
There was a problem hiding this comment.
I can do this in a follow-up but I'd prefer to avoid r#gen. I understand it's the machine-applicable way to migrate from one edition to another but no one really wants to either read or write r#gen over time so I'd prefer to go through and update things to generator or similar.
Signed-off-by: Joel Dice <[email protected]>
Collaborator
Author
|
I'm going to try to fix the |
Signed-off-by: Joel Dice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
wit-bindgen-rtetc. to use (some of) the new ABI defined in WebAssembly/component-model#524. It covers everything in that PR except the lifting and lowering changes tofuture.{read,write}, which we decided are more trouble than they're worth.I've tested this end-to-end with
wasip3-prototypingand will soon post a corresponding PR there.Finally,
rustfmtwas complaining about usinggenas a field name, so I took this opportunity to address that.