Skip to content

Fix for #2798 #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix for #2798 #2816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bfb579
chore(version): bump to v0.7.20
Oct 5, 2020
6e10da6
Fix for #2798. Hide title when there is no data is empty.
Oct 5, 2020
1b5b057
undo changes to sample data
Oct 5, 2020
effe7a1
Merge branch 'master' of https://github.com/morgan12/c3
Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/arc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,10 +702,7 @@ ChartInternal.prototype.redrawArc = function(
.style('opacity', function(d) {
return $$.isTargetToShow(d.data.id) && $$.isArcType(d.data) ? 1 : 0
})
main
.select('.' + CLASS.chartArcsTitle)
.style('opacity', $$.hasType('donut') || hasGaugeType ? 1 : 0)


if (hasGaugeType) {
let index = 0
const backgroundArc = $$.arcs
Expand Down
5 changes: 5 additions & 0 deletions src/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,11 @@ ChartInternal.prototype.redraw = function(options, transitions) {
.transition()
.style('opacity', targetsToShow.length ? 0 : 1)

// Only show arc title if chart type is donut or gauge and if there are any data to show
main
.select('.' + CLASS.chartArcsTitle)
.style('opacity', ($$.hasType('donut') || $$.hasType('gauge')) && targetsToShow.length > 0 ? 1 : 0)

// event rect
if (withEventRect) {
$$.redrawEventRect()
Expand Down