opts.db to pass durable storage#41
Merged
Merged
Conversation
Member
|
Yes! Awesome. This is a great stepping stone toward having durable storage for the various cabal clients too. I used memdb originally because kappa view didn't yet have versioning support, but that got implemented months ago. |
Member
|
5.1.0 |
Member
|
Ah, this is actually BREAKING for clients that use the unofficial @nikolaiwarner cc ^^ |
Member
|
@noffle Let me know what I need to change and I'll patch up all the clients! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes it possible to use durable storage from a levelup or leveldown instance as
opts.dbinstead of always using memdb.