*middleware.responseRecorder is not http.Hijacker: missing method Hijack

[lmas]

Hello, I'm getting this error when trying the websocket stuff with caddy and using Go 1.4.2.
Running caddy with:

localhost
log stdout
errors stdout
websocket /echo cat

And when I try to test that websocket, using ws (for simplicity's sake):

ws ws://localhost:2015/echo

I get this error in the caddy log (and the ws script fails with a "bad status"):

[PANIC /echo] /home/lmas/.go/src/golang.org/x/net/websocket/server.go:74 - interface conversion: *middleware.responseRecorder is not http.Hijacker: missing method Hijack
127.0.0.1 - [11/Jun/2015:21:57:20 +0200] "GET /echo HTTP/1.1" 500 26

Another thing I noticed is that if I instead try to run:

ws ws://127.0.0.1:2015/echo

I get no errors in the caddy logs but ws fails again with the same message.

Any ideas why this is happening? Any suggestions for how to fix it?

[mholt]

Ah, nuts. I know why that's happening. If you take out the log directive it should work.

I won't have a chance to fix this today, but maybe somebody else will before I can get around to it?

[mholt]

Basically, log is replacing the net/http ResponseWriter with its own responseRecorder, which is not a hijacker. Log shouldn't be logging ws requests, I think - they're not regular HTTP requests in that regard.

[tw4452852]

Why not we just implement http.Hijacker if any ?

[lmas]

I haven't looked at the source yet, but will ws errors still be logged in
some other way if we remove that log? Or is it the only logger for ws?
On Jun 12, 2015 5:16 AM, "Tw" notifications@github.com wrote:

Why not we just implement http.Hijacker if any ?

—
Reply to this email directly or view it on GitHub
#133 (comment).

[mholt]

@lmas log only logs accesses; errors logs errors, but does not replace the ResponseWriter. I need to double-check how log should be handling websocket connections.

[lmas]

Oh you meant THAT log. Nevermind me then.
On Jun 12, 2015 3:24 PM, "Matt Holt" notifications@github.com wrote:

@lmas https://github.com/lmas log only logs accesses; errors logs
errors, but does not replace the ResponseWriter. I need to double-check how
log should be handling websocket connections.

—
Reply to this email directly or view it on GitHub
#133 (comment).

[mholt]

Closed with #134 - honestly, I'm surprised that worked. 💯

[lmas]

Hell yeah! Thanks guys!