Skip to content

chore(active-active): delete unused field #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shaddoll merged 1 commit into from
Oct 27, 2025
Merged

chore(active-active): delete unused field #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
171 changes: 80 additions & 91 deletions go/proto/admin/v1/queue.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

325 changes: 156 additions & 169 deletions go/proto/admin/v1/replication.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

325 changes: 156 additions & 169 deletions go/proto/admin/v1/service.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

638 changes: 89 additions & 549 deletions go/proto/api/v1/common.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

171 changes: 80 additions & 91 deletions go/proto/api/v1/common.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

171 changes: 80 additions & 91 deletions go/proto/api/v1/decision.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

335 changes: 78 additions & 257 deletions go/proto/api/v1/domain.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

325 changes: 156 additions & 169 deletions go/proto/api/v1/domain.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

171 changes: 80 additions & 91 deletions go/proto/api/v1/history.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

171 changes: 80 additions & 91 deletions go/proto/api/v1/query.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

351 changes: 93 additions & 258 deletions go/proto/api/v1/service_domain.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

509 changes: 247 additions & 262 deletions go/proto/api/v1/service_domain.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

171 changes: 80 additions & 91 deletions go/proto/api/v1/service_visibility.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

171 changes: 80 additions & 91 deletions go/proto/api/v1/service_worker.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

171 changes: 80 additions & 91 deletions go/proto/api/v1/service_workflow.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

171 changes: 80 additions & 91 deletions go/proto/api/v1/visibility.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

171 changes: 80 additions & 91 deletions go/proto/api/v1/workflow.pb.yarpc.go
View file
Open in desktop

Large diffs are not rendered by default.

27 changes: 3 additions & 24 deletions proto/uber/cadence/api/v1/common.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,26 +136,10 @@ message AsyncWorkflowConfiguration {
DataBlob queue_config = 4;
}

// todo (david.porter) to remove as this is no longer used
enum ActiveClusterSelectionStrategy {
ACTIVE_CLUSTER_SELECTION_STRATEGY_INVALID = 0;
ACTIVE_CLUSTER_SELECTION_STRATEGY_REGION_STICKY = 1;
ACTIVE_CLUSTER_SELECTION_STRATEGY_EXTERNAL_ENTITY = 2;
}

message ActiveClusterSelectionPolicy {
ActiveClusterSelectionStrategy strategy = 1; // todo (david.porter) to remove

// todo (david.porter) to remove
oneof strategy_config {
// Sticky region config is applicable if strategy is ACTIVE_CLUSTER_SELECTION_STRATEGY_REGION_STICKY
// This is the default strategy for active-active domains and region would be set to receiver cluster's region if not specified.
ActiveClusterStickyRegionConfig active_cluster_sticky_region_config = 2;

// External entity config is applicable if strategy is ACTIVE_CLUSTER_SELECTION_STRATEGY_EXTERNAL_ENTITY
// External entity type must be one of the supported types in active cluster manager. Custom ones can be added by implementing the corresponding interface.
ActiveClusterExternalEntityConfig active_cluster_external_entity_config = 3;
}
reserved 1;
reserved 2;
reserved 3;
ClusterAttribute cluster_attribute = 4;
}

Expand All @@ -179,11 +163,6 @@ message ClusterAttribute {
string name = 2;
}

// todo (david.porter) to remove as this is no longer used
message ActiveClusterStickyRegionConfig {
string sticky_region = 1;
}

// FailoverType describes how a failover operation will be performed.
enum FailoverType {
FAILOVER_TYPE_INVALID = 0;
Expand Down
2 changes: 1 addition & 1 deletion proto/uber/cadence/api/v1/domain.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ enum ArchivalStatus {

// ActiveClusters contains the configuration of active-active domain's active clusters/regions
message ActiveClusters {
map<string, ActiveClusterInfo> region_to_cluster = 1; // todo (david.porter) to remove as this is no longer used
reserved 1;
map<string, ClusterAttributeScope> active_clusters_by_cluster_attribute = 2;
}

Expand Down
2 changes: 1 addition & 1 deletion proto/uber/cadence/api/v1/service_domain.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ message RegisterDomainRequest {
string history_archival_uri = 11;
ArchivalStatus visibility_archival_status = 12;
string visibility_archival_uri = 13;
map<string, string> active_clusters_by_region = 14; // todo (david.porter) to remove as this is no longer used
reserved 14;
ActiveClusters active_clusters = 15;
}

Expand Down
13 changes: 6 additions & 7 deletions thrift/shared.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1131,7 +1131,7 @@ struct ClusterAttributeScope {
// }
// }
struct ActiveClusters {
10: optional map<string, ActiveClusterInfo> activeClustersByRegion // todo (david.porter) remove this as it's no longer used
// deprecated 10: optional map<string, ActiveClusterInfo> activeClustersByRegion
11: optional map<string, ClusterAttributeScope> activeClustersByClusterAttribute
}

Expand All @@ -1150,8 +1150,7 @@ struct RegisterDomainRequest {
50: optional bool emitMetric = true
60: optional list<ClusterReplicationConfiguration> clusters
70: optional string activeClusterName
// todo (david.porter) remove this field as it's not going to be used
75: optional map<string, string> activeClustersByRegion
// deprecated 75: optional map<string, string> activeClustersByRegion
// activeClusters is a map of cluster-attribute name to active cluster name for active-active domain
76: optional ActiveClusters activeClusters
// A key-value map for any customized purpose
Expand Down Expand Up @@ -2201,10 +2200,10 @@ struct TaskKey {
struct ActiveClusterSelectionPolicy {
1: optional ClusterAttribute clusterAttribute

10: optional ActiveClusterSelectionStrategy strategy // todo (david.porter) remove these as they're not used anymore
20: optional string stickyRegion // todo (david.porter) remove these as they're not used anymore
30: optional string externalEntityType // todo (david.porter) remove these as they're not used anymore
40: optional string externalEntityKey // todo (david.porter) remove these as they're not used anymore
// deprecated 10: optional ActiveClusterSelectionStrategy strategy
// deprecated 20: optional string stickyRegion
// deprecated 30: optional string externalEntityType
// deprecated 40: optional string externalEntityKey
}

// ClusterAttribute is used for subdividing workflows in a domain into their active
Expand Down