Skip to content

Conversation

@Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Oct 30, 2025

This reverts commit 0857e50.

The long-term goal is to remove the fields. We're adding it back because of some legacy buggy code in server making the change non-backward compatible and not safe to rollback. The plan is to fix the bug to create a commit that's safe to rollback and then redo this change again.

Summary

[Brief summary of the change, including the rationale and intended effect]

Type of Change

  • Add new API(s)
  • Add new data type(s)
  • Add new field(s) to existing data type
  • Remove field(s) from data type
  • Remove data type(s)
  • Remove API(s)
  • Other (please provide detailed description)

Data Effect

  • Does it change the data stored in database?

Detailed Description

[In-depth description of the changes made to the IDL, specifying new fields, removed fields, or modified data structures]

Impact Analysis

  • Backward Compatibility: [Analysis of backward compatibility]
  • Forward Compatibility: [Analysis of forward compatibility]

Testing Plan

  • Unit Tests: [Do we have unit test covering the change?]
  • Persistence Tests: [If the change is related to a data type which is persisted, do we have persistence tests covering the change?]
  • Integration Tests: [Do we have integration test covering the change?]
  • Compatibility Tests: [Have we done tests to test the backward and forward compatibility?]

Rollout Plan

  • What is the rollout plan?
  • Does the order of deployment matter?
  • Is it safe to rollback? Does the order of rollback matter?
  • Is there a kill switch to mitigate the impact immediately?

@Shaddoll Shaddoll changed the title Revert "chore(active-active): delete unused field (#232)" fix: Revert "chore(active-active): delete unused field (#232)" Oct 30, 2025
@Shaddoll Shaddoll merged commit a2d398f into master Oct 30, 2025
9 of 11 checks passed
@Shaddoll Shaddoll deleted the aa branch October 30, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants