Skip to content

Conversation

@neil-xie
Copy link
Member

Summary

[Brief summary of the change, including the rationale and intended effect]
Add CronSchedule, ExecutionStatus and ScheduledExecutionTime to visibility workflow execution info

Type of Change

  • Add new API(s)
  • Add new data type(s)
  • Add new field(s) to existing data type
  • Remove field(s) from data type
  • Remove data type(s)
  • Remove API(s)
  • Other (please provide detailed description)

Data Effect

  • Does it change the data stored in database?

Detailed Description

[In-depth description of the changes made to the IDL, specifying new fields, removed fields, or modified data structures]
Adding CronSchedule, ExecutionStatus and ScheduledExecutionTime fields to workflowExecutionInfo and new enum for workflowExecutionStatus

Impact Analysis

  • Backward Compatibility: [Analysis of backward compatibility] Yes
  • Forward Compatibility: [Analysis of forward compatibility] Yes

Testing Plan

  • Unit Tests: [Do we have unit test covering the change?] idl change
  • Persistence Tests: [If the change is related to a data type which is persisted, do we have persistence tests covering the change?] NA
  • Integration Tests: [Do we have integration test covering the change?] NA
  • Compatibility Tests: [Have we done tests to test the backward and forward compatibility?] NA

Rollout Plan

  • What is the rollout plan? pull into cadence repo
  • Does the order of deployment matter?
  • Is it safe to rollback? Does the order of rollback matter?
  • Is there a kill switch to mitigate the impact immediately?

@neil-xie neil-xie changed the title Add cron and execution related fiedls to visibility feat: Add cron and execution related fiedls to visibility Dec 10, 2025
Copy link
Member

@timl3136 timl3136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

110: optional ResetPoints autoResetPoints
120: optional string taskList
121: optional TaskList taskListInfo
130: optional bool isCron
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are adding cronSchedule field, perhaps we can think about removing this field in the future

@neil-xie neil-xie merged commit a5ebf5f into cadence-workflow:master Dec 11, 2025
7 of 8 checks passed
@neil-xie neil-xie deleted the CDNC-16908 branch December 11, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants