fix: Show "primary" label next to clusters in active-active domains #1051
+178
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
adhityamamallan
force-pushed
the
primary-cluster
branch
from
3714010 to
2b8c0f2
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds visual indicators to distinguish cluster replication roles in active-active domains. The change introduces a new helper function that returns appropriate labels ("primary", "active", or "passive") based on domain type and cluster status, then applies these labels in the cluster dropdown selector and domain metadata display.
Key changes:
- Created
getClusterReplicationStatusLabelhelper that returns "primary" for active clusters in active-active domains, "active"/"passive" for active-passive domains, and undefined for non-primary clusters in active-active domains - Updated cluster dropdown and metadata displays to show replication status labels conditionally
- Added comprehensive test coverage for the new labeling behavior across different domain types
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/views/domain-page/helpers/get-cluster-replication-status-label.ts |
New helper function to determine cluster replication status labels based on domain type |
src/views/domain-page/helpers/__tests__/get-cluster-replication-status-label.test.ts |
Unit tests covering all cases for the new helper function |
src/views/domain-page/helpers/__mocks__/get-cluster-replication-status-label.ts |
Mock implementation of the helper for testing |
src/views/domain-page/domain-page-metadata-clusters/domain-page-metadata-clusters.tsx |
Integrated helper to conditionally display labels in cluster metadata |
src/views/domain-page/domain-page-metadata-clusters/__tests__/domain-page-metadata-clusters.test.tsx |
Added test for active-active domain label display |
src/views/domain-page/domain-page-cluster-selector/domain-page-cluster-selector.tsx |
Integrated helper into cluster selector dropdown options |
src/views/domain-page/domain-page-cluster-selector/__tests__/domain-page-cluster-selector.test.tsx |
Updated tests to verify label display in dropdown for both domain types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Assem-Uber
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Show cluster replication status label next to cluster names in the Cluster Dropdown and in the Clusters list in Domain Metadata
Test plan
Updated unit tests + ran locally.