Skip to content

Misc Domain Page refactoring #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 11, 2025
Merged

Misc Domain Page refactoring #867

merged 6 commits into from
Apr 11, 2025

Conversation

@adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Apr 9, 2025 •
edited
Loading

Summary

  • Rename DomainInfo to DomainDescription
  • Add common hook useSuspenseDomainDescription to load domain description
  • Move generated Domain type to route handlers
  • Fix lint warnings in archival header
  • Add hook for DomainPageMetadata, which can be overridden with additional domain metadata

Test plan

Unit tests passing + ran locally to sanity-check.

@adhityamamallan adhityamamallan marked this pull request as ready for review April 9, 2025 08:47
@adhityamamallan adhityamamallan merged commit 32a7dc5 into cadence-workflow:master Apr 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Assem-Uber Assem-Uber Assem-Uber approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adhityamamallan @Assem-Uber