Skip to content

Conversation

@Assem-Uber
Copy link
Contributor

@Assem-Uber Assem-Uber commented Apr 10, 2025

Summary

Create form for workflow reset action. It accepts eventId, reason and a flag to skip applying signals. The form is not integrated with the workflow actions modal yet. This will be in upcoming PR.

Screenshots

Screenshot 2025-04-10 at 08 37 21
Screenshot 2025-04-10 at 08 37 08

@Assem-Uber Assem-Uber requested a review from Copilot April 10, 2025 06:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/views/workflow-actions/workflow-action-reset-form/tests/workflow-action-reset-form.test.tsx:61

  • The test expects a null value for the event ID input while the component sets a default value of an empty string. Consider updating either the test or the component default to ensure consistency.
    expect(eventIdInput).toHaveValue(null);

…-action-reset-form.tsx

Co-authored-by: Adhitya Mamallan <[email protected]>
@Assem-Uber Assem-Uber merged commit f4b9c07 into cadence-workflow:master Apr 10, 2025
1 check passed
@Assem-Uber Assem-Uber deleted the feature/12780/add-reset-form-component branch April 10, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants