-
Notifications
You must be signed in to change notification settings - Fork 125
Reset form component #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Assem-Uber
merged 10 commits into
cadence-workflow:master
from
Assem-Uber:feature/12780/add-reset-form-component
Apr 10, 2025
Merged
Reset form component #869
Assem-Uber
merged 10 commits into
cadence-workflow:master
from
Assem-Uber:feature/12780/add-reset-form-component
Apr 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/views/workflow-actions/workflow-action-reset-form/tests/workflow-action-reset-form.test.tsx:61
- The test expects a null value for the event ID input while the component sets a default value of an empty string. Consider updating either the test or the component default to ensure consistency.
expect(eventIdInput).toHaveValue(null);
src/views/workflow-actions/workflow-action-reset-form/workflow-action-reset-form.tsx
Show resolved
Hide resolved
src/views/workflow-actions/workflow-action-reset-form/workflow-action-reset-form.tsx
Show resolved
Hide resolved
adhityamamallan
approved these changes
Apr 10, 2025
src/views/workflow-actions/workflow-action-reset-form/workflow-action-reset-form.tsx
Show resolved
Hide resolved
…-action-reset-form.tsx Co-authored-by: Adhitya Mamallan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create form for workflow reset action. It accepts eventId, reason and a flag to skip applying signals. The form is not integrated with the workflow actions modal yet. This will be in upcoming PR.
Screenshots