Remove copy button from pending events in workflow history #979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the Copy Link to Event button from pending events in workflow history views to prevent deep-linking to temporary events that will become invalid once written to history.
- Add conditional checks for
eventIdpresence before rendering copy buttons - Hide copy button for pending events in both grouped and ungrouped views
- Add comprehensive test coverage for the new behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| workflow-history-ungrouped-event.tsx | Adds eventId check to conditionally render copy button in ungrouped view |
| workflow-history-ungrouped-event.test.tsx | Adds tests verifying copy button visibility for regular and pending events |
| workflow-history-events-card.tsx | Adds eventId check to conditionally render copy button in grouped view |
| workflow-history-events-card.test.tsx | Adds tests verifying copy button behavior for regular and pending events |
...views/workflow-history/workflow-history-ungrouped-event/workflow-history-ungrouped-event.tsx
Show resolved
Hide resolved
src/views/workflow-history/workflow-history-events-card/workflow-history-events-card.tsx
Show resolved
Hide resolved
Assem-Uber
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since pending events in the workflow history are only present temporarily, we do not want to support deep-linking to them because the deep link will no longer be valid once the event is actually written to history. This PR hides the Copy Link to Event button for pending events.
Test plan
Added unit tests + ran locally.
In grouped view:
In ungrouped view:
