Skip to content

feat(iOS): rewrite old arch to use UIScrollView #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 25, 2023
Merged

feat(iOS): rewrite old arch to use UIScrollView #681

merged 8 commits into from
Jan 25, 2023

Conversation

okwasniewski
Copy link
Member

@okwasniewski okwasniewski commented Jan 18, 2023 •
edited
Loading

Summary

This PR rewrites old architecture of react-native-pager-view to UIScrollView on iOS.

Test Plan

Launch the example app.

Compatibility

OS Implemented
iOS ✅
Android ❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

Known issues

  • Swiping right on last page is stuck on settling when overdrag is disabled.

@okwasniewski okwasniewski changed the base branch from master to next January 18, 2023 10:44
krozniata
krozniata reviewed Jan 18, 2023
View reviewed changes
@okwasniewski okwasniewski force-pushed the feat/old-arch-scrollview branch from 204a4d3 to 0575bcb Compare January 18, 2023 11:17
krozniata
krozniata reviewed Jan 19, 2023
View reviewed changes
@andreialecu
Copy link
Contributor

I'm curious about how this is different from a regular RN ScrollView with pagingEnabled: true?

I had issues with RN ScrollView in the past and moved to react-native-pager-view specifically to solve those.

Issues were: it would randomly get stuck between pages at some points, and performance seemed worse in general, especially with Reanimated and complex interactions.

@okwasniewski
Copy link
Member Author

Hey @andreialecu! 



There are quite a lot of differences between those two implementations. The Core RN ScrollView is a generic scrolling component written to support as many use cases as possible to be the “go-to” scrolling component.

Both implementations are based on the native UIScrollView component, but pager's implementation is focused on providing the best paging experience possible, while keeping the same API as old implementation. You can read more about the motivation here: #673

Also, we are going to soon release pager-view 7.0.0-next it would be awesome If you could test it out on your specific use case and let us know if you have any performance issues.

@troZee troZee merged commit bdf7de4 into next Jan 25, 2023
@troZee troZee deleted the feat/old-arch-scrollview branch January 25, 2023 19:38
troZee added a commit that referenced this pull request Mar 31, 2024
@troZee @krozniata
@okwasniewski @intergalacticspacehighway @ku8ar @igorbej
merge next to master (#817)
280c3a3 
* feat(iOS): change Fabric implementation to UIScrollView (#672)

* feat(iOS): change Fabric implementation to UIScrollView

* fix: fix offset values in vertical orientation

* feat: add initialPage props support

* feat: add RTL language support

* feat: add pageMargin prop support

* fix: fix typescript error

* feat: remove React.cloneElement

* feat(ios): add getPageOffset method

* fix: fix styles in old example

* fix: behavior on page remove

* chore: add GH actions (#680)

Co-authored-by: Piotr Trocki <[email protected]>

* feat(iOS): rewrite old arch to use UIScrollView (#681)

* feat: rewrite old arch to use UIScrollView

* feat: update example styles

* fix: sending event on scrollViewDidEndDecelerating

* feat: properly calculate width using orientation

* fix: change way of disabing scroll

* feat: rename to RNCPagerView

* fix: removing last page

* fix: remove unused properties, set animated

* chore: update release script

* Release 7.0.0-rc.0

* wip

* wip

* fabric example

* nit: comment

* make init consistent

* fix: multiple updates of frame and contentSize

* feat: add button to quickly switch layout direction

* sync with master (#756)

Co-authored-by: Piotr Trocki <[email protected]>

* chore: upgrade RN (paper example)

* chore: upgrade rn & fix issues (fabric example)

* chore: bump versions in package.json

* chore: fix eslint issue

* chore: exclude example from tsc

* feat(next): remove fabric example

* chore: update README

* fix broken overdrag on notch (#787)

Co-authored-by: Kuba Juszczyk <[email protected]>

* feat(iOS): Add a `useLegacy` flag to switch between the old/new iOS implementation (#783)

* wip: unsuspicious changes

* wip: unsuspicious changes v2

* FABRIC NEW IMPL -> OLD IMPL

* wip: bring back useLegacy on the RN side

* wip: bring back duplicate types to fix codegen issues

* wip: remove #705 related code for now

* wip: old/new impl division first draft

* wip: old/new impl division continued

* wip: old/new impl v3

* wip: add a `LEGACY_` prefix to all legacy implementation-related symbols

* wip: fix styles for new implementation on Fabric

* wip: move old/new impl into separate folders

* wip: fix old impl fabric symbol names

* wip: xcode changes

* wip: clean up & unify the naming convention

* wip: fix linter issues

* wip: fix styles for new implementation on Paper

* wip: make Fabric example run on another port by default to make it possible to run both examples in parallel

* wip: implement an abstraction over native commands invocations to reduce branching

* refactor: remove the unnecessary value for boolean props

* fix: bump react-native-safe-area-context to a Fabric-enabled version

* feat: bring back & adjust the `bootstrap-fabric` script

* feat: adjust the home screen title depending on the used architecture

* chore: update example/Podfile.lock

* chore: update an Xcode project file after building

* ci: make next branch events trigger ios/android build workflows

* chore: remove commented-out code related to #705 for now

* chore: add legacy implementation explanation comment

* wip: Android fixes

* fix: unnecessary comma in MainActivity.java

* feat: readme makeover

* chore: bump react-native-screens & react-native-gesture-handler in example

* refactor(android): extract module name to shared variable, add comment for context

* chore: remove unnecessary yarn.lock deps

* chore(ios): bring back removed build flags

* chore(ios): remove unnecessary concurrentRootEnabled method

According to React Native Upgrade Helper, this method is to be removed when updating to RN 0.72:
https://react-native-community.github.io/upgrade-helper/?from=0.71.14&to=0.72.0#RnDiffApp-ios-RnDiffApp-AppDelegate.mm

* fix(android): adjust incorrect param type on Fabric

* chore: remove unnecessary tsconfig.json comment

* chore(ios): bring back (currently unused) code related to #712 and #705

* Release 7.0.0-rc.1

* fix(ios): fix freezing when navigating to same index (#804)

* Release 7.0.0-rc.2

* fix iOS issue

* Change Legacy basic example into the next basic example

* revert documentatation

---------

Co-authored-by: Kacper Rożniata <[email protected]>
Co-authored-by: Piotr Trocki <[email protected]>
Co-authored-by: Oskar Kwaśniewski <[email protected]>
Co-authored-by: Nishan <[email protected]>
Co-authored-by: Kuba Juszczyk <[email protected]>
Co-authored-by: Kuba Juszczyk <[email protected]>
Co-authored-by: Igor Bejnarowicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krozniata krozniata krozniata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@okwasniewski @andreialecu @krozniata @troZee