Skip to content

Conversation

TechWilk
Copy link
Contributor

Motivation

Fix hitslop on the Button component which was previously being passed to the wrong child component

Related issue

#4677

Test plan

  1. Create a button
  2. Apply a large value with the hitslop prop
  3. Observe that you can press outside of the button which triggers both the animation and onPress action

e.g.

<Button
          mode="contained"
          onPress={() => console.log("pressed")}
          hitSlop={300}
>
          Press me
</Button>

@callstack-bot
Copy link

Hey @TechWilk, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@TechWilk TechWilk changed the title fix(button): hitslop passed to touchable fix(button): pass hitSlop to touchable May 1, 2025
@lukewalczak lukewalczak added this to the 5.14.1 milestone May 6, 2025
@lukewalczak lukewalczak merged commit 6207a6c into callstack:main May 7, 2025
3 checks passed
lukewalczak pushed a commit that referenced this pull request May 7, 2025
lukewalczak pushed a commit that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants