Add act to update call to support hooks #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
requested changes
Mar 23, 2019
src/__tests__/act.test.js
Outdated
| @@ -28,6 +28,14 @@ test('render should trigger useEffect', () => { | |||
| expect(effectCallback).toHaveBeenCalledTimes(1); | |||
| }); | |||
|
|
|||
| test('updaate should trigger useEffect', () => { | |||
src/render.js
Outdated
| @@ -46,6 +46,15 @@ function renderWithAct( | |||
| return ((renderer: any): ReactTestRenderer); | |||
| } | |||
|
|
|||
| function updateWithAct(renderer: ReactTestRenderer) { | |||
| function updateImpl(component: React.Element<any>) { | |||
|
Thanks for the response! I made a couple updates, let me know if there's anything else outstanding. |
Esemesek
approved these changes
Mar 25, 2019
|
Thank you for this PR ❤️ ❤️ ❤️ |
|
Of course! I've got a couple more coming up in the next few days, more type inference for the typescript typings file and a hook specific API a la react-hooks-testing-library (this might require some discussion). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently
renderandfireEventare wrapped inactto support hooks. This pull request wraps the update call inactto support testing component updates (e.g. prop changes).Test plan
__tests__/act.test.js.updatecalls (if the hook dependency array is satisfied).