docs: add migration to v7 guide #456
Conversation
thymikee
force-pushed
the
feat/migration-guide-7
branch
from
30ad0c5 to
5cc1007
Compare
|
We can merge this guide before the actual migration, because it won't show up in the guides just yet. It will be hidden under "/react-native-testing-library/docs/migration-v7" link for now. EDIT: nevermind, I've created 7.x branch so we can merge anytime anyway. |
There was a problem hiding this comment.
Solid 💯 I'm thrilled how simple this will be to migrate. Thank you for all your work @thymikee!
thymikee
force-pushed
the
feat/migration-guide-7
branch
from
bbb8b18 to
116ef86
Compare
thymikee
force-pushed
the
feat/migration-guide-7
branch
from
116ef86 to
3e9bfbc
Compare
thymikee
force-pushed
the
feat/migration-guide-7
branch
from
3d59e3f to
7b564de
Compare
|
|
||
| ## No special handling for `disabled` prop | ||
|
|
||
| The `disabled` prop on "Touchable\*" components is treated in the same manner as any other prop. We realize that with our library you can press "touchable" components even though they're in "disabled" state, however this is something that we strongly believe should be fixed upstream, in React Native core. |
There was a problem hiding this comment.
From what I can read in RNTL code it seems that the logic is to find prop with given name (e.g. onPress for press event) and just run it. I'm not sure how this should be fixed by RN, so that we could use it in RNTL, as we are executing the prop function without delegating event logic to RN. One option for RN would be to automatically wrap onPress assignment which would add if(!disabled) check, but this will actually assign a different function there.
There was a problem hiding this comment.
We could try adding onStartShouldSetResponder check support, which should solve this particular problem. Likely not thorough enough to improve whole event firing system, but maybe it's a good start.
There was a problem hiding this comment.
Went ahead and merged the guide, we can still amend it when we decide to act on this topic
Co-authored-by: Maciej Jastrzebski <[email protected]>
Co-authored-by: Maciej Jastrzebski <[email protected]>
Co-authored-by: Maciej Jastrzebski <[email protected]>
Co-authored-by: Maciej Jastrzebski <[email protected]>
* docs: add migration to v7 guide * adjust note about ByTitle because there's no host Button component * add fire event section * mention NativeTestInstance and container * Update website/docs/MigrationV7.md Co-authored-by: Maciej Jastrzebski <[email protected]> * Update website/docs/MigrationV7.md Co-authored-by: Maciej Jastrzebski <[email protected]> * Update website/docs/MigrationV7.md Co-authored-by: Maciej Jastrzebski <[email protected]> * Update website/docs/MigrationV7.md Co-authored-by: Maciej Jastrzebski <[email protected]> Co-authored-by: Maciej Jastrzebski <[email protected]>
* docs: add migration to v7 guide * adjust note about ByTitle because there's no host Button component * add fire event section * mention NativeTestInstance and container * Update website/docs/MigrationV7.md Co-authored-by: Maciej Jastrzebski <[email protected]> * Update website/docs/MigrationV7.md Co-authored-by: Maciej Jastrzebski <[email protected]> * Update website/docs/MigrationV7.md Co-authored-by: Maciej Jastrzebski <[email protected]> * Update website/docs/MigrationV7.md Co-authored-by: Maciej Jastrzebski <[email protected]> Co-authored-by: Maciej Jastrzebski <[email protected]>
Summary
Closes #442
Test plan