Skip to content

fix: hermes xcode build scripts #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix: hermes xcode build scripts #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/react-native/sdks/hermes-engine/utils/build-hermes-xcode.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@ function get_platform_copy_destination {
if [[ $1 == "macosx" ]]; then
echo "macosx"
return
elif [[ $1 == "xros" ]]; then
echo "xros"
return
elif [[ $1 == "xrsimulator" ]]; then
elif [[ $1 == "xrsimulator" || $1 == "xros" ]]; then
echo "xros"
return
fi
Expand All @@ -31,8 +28,10 @@ function get_deployment_target {
if [[ $1 == "macosx" ]]; then
echo ${MACOSX_DEPLOYMENT_TARGET}
return
elif [[ $1 == "xrsimulator" || $1 == "xros" ]]; then
echo ${XROS_DEPLOYMENT_TARGET}
return
fi

echo ${IPHONEOS_DEPLOYMENT_TARGET}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/template/visionos/HelloWorld/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class AppDelegate: RCTAppDelegate {

override func bundleURL() -> URL? {
#if DEBUG
RCTBundleURLProvider.sharedSettings()?.jsBundleURL(forBundleRoot: "index")
RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "index")
#else
Bundle.main.url(forResource: "main", withExtension: "jsbundle")
#endif
Expand Down