feat: Dynamic generate agent #2540

Yuujee · 2025-06-02T11:22:49Z

Description

Describe your changes in detail (optional if the linked issue already contains a detailed description of the changes).

Checklist

Go over all the following points, and put an x in all the boxes that apply.

I have read the CONTRIBUTION guide (required)
I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
I have updated the tests accordingly (required for a bug fix or a new feature)
I have updated the documentation if needed:
I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

Yuujee · 2025-06-02T14:56:19Z

I'm considering add a tool_rag_selector. It can search suitable tools by rag.

zjrwtx

thanks @Yuujee ,I did a preliminary quick review，left some comment

zjrwtx · 2025-06-03T10:08:47Z

camel/societies/workforce/dynamic_agent.py

+        self.tool_selector = tool_selector
+
+    def generate_prompt(self, task_content: str) -> dict:
+        prompt = TextPrompt(


could you add more docstring below these function in dynamic_agent?

zjrwtx · 2025-06-03T10:25:00Z

thanks @Yuujee ,i think there are some papers related to tool rag with graph etc，it would be better to do some prestudy.If you need help, feel free to tell us，thanks

Yuujee · 2025-06-03T11:06:53Z

Thanks for your comment @zjrwtx ! I will fix the code recently. And I will do some prestudy about tool_rag. Maybe we could open another issue about it?

zjrwtx · 2025-06-03T11:20:20Z

Thanks for your comment @zjrwtx ! I will fix the code recently. And I will do some prestudy about tool_rag. Maybe we could open another issue about it?

thanks @Yuujee , agree with you!

Wendong-Fan

thanks @Yuujee's contribution, left some comments below, could we also add this dynamic agent building feature into workforce class as default setting?

Wendong-Fan · 2025-06-03T14:00:58Z

camel/societies/workforce/tool_selector.py

+from typing import Any, List
+
+from camel.toolkits import ACIToolkit
+from examples.toolkits.aci_toolkit import LINKED_ACCOUNT_OWNER


we'd better set the variable directly, instead of importing from example code

Wendong-Fan · 2025-06-03T14:04:27Z

camel/societies/workforce/tool_selector.py

+    r"""
+    Abstract base class for all tool selectors.


docstring format

Suggested change

r"""

Abstract base class for all tool selectors.

r"""Abstract base class for all tool selectors.

Wendong-Fan · 2025-06-03T14:07:40Z

camel/societies/workforce/tool_selector.py

+    def select_tools(self, task_content: str) -> list:
+        r"""
+        Searches for functions via ACI Toolkit based on the task intent.
+
+        Args:
+            task_content (str): Description of the task for function discovery.
+
+        Returns:
+            List[FunctionTool]: A list of matched function tools.
+        """
+        return self.aci_toolkit.get_tools()


seems now we just returned all the toolkits instead of selecting the tool?

Yes. ACIFunctionToolSelector provides a way to finish the task by aciToolkit. And I will add a mcpToolSelector later. Through the mcpToolSelector we can select McpTools, but it's can only for the mcp. Maybe I could open another issue to realize a rag_tool_selector to support internal toolkits search from camel.

for now maybe we could refer to https://docs.camel-ai.org/cookbooks/advanced_features/agents_with_MCP#mcp-search-agents to implement it, we also have example code for aci.dev here: https://github.com/camel-ai/camel/blob/master/examples/agents/mcp_agent/mcp_agent_using_registry.py

I am a little confused.If we use McpAgent to search the tools we need, then we need to use it to call the tools.So why not use McpAgent directly?

Wendong-Fan · 2025-06-03T14:11:50Z

camel/societies/workforce/dynamic_agent.py

+        model_config_dict = ChatGPTConfig(temperature=0.0).as_dict()
+        model = ModelFactory.create(
+            model_platform=ModelPlatformType.DEFAULT,
+            model_type=ModelType.DEFAULT,
+            model_config_dict=model_config_dict,


maybe better support take agent as argument instead of hard coding the model

Wendong-Fan · 2025-06-03T14:12:51Z

camel/societies/workforce/dynamic_agent.py

+        )
+
+        agent = ChatAgent(system_message=prompt, model=model)
+        response = agent.step(task_content)


use structured output feature? refer: https://github.com/camel-ai/camel/blob/master/examples/structured_response/json_format_response.py

Wendong-Fan · 2025-06-03T14:13:45Z

camel/societies/workforce/dynamic_agent.py

+        # Step 3: Build model configuration
+        model_config_dict = ChatGPTConfig(
+            tools=tools,
+            temperature=0.0
+        ).as_dict()
+
+        model = ModelFactory.create(
+            model_platform=ModelPlatformType.DEFAULT,
+            model_type=ModelType.DEFAULT,
+            model_config_dict=model_config_dict,
+        )


same as above, don't hard code the model type

…amic_generate_agent

coderabbitai · 2025-06-03T14:49:12Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Yuujee added 3 commits June 2, 2025 18:23

Feat(dynamic generate agent)

d17d15f

Fix(add example code and add aciSelector)

effc831

Fix(add example code and add aciSelector)

ab7252c

Yuujee linked an issue Jun 2, 2025 that may be closed by this pull request

[Feature Request] Optimize new_worker_agent setting in Workforce #2470

Open

2 tasks

Yuujee self-assigned this Jun 2, 2025

Yuujee removed a link to an issue Jun 2, 2025

[Feature Request] Optimize new_worker_agent setting in Workforce #2470

Open

2 tasks

Yuujee linked an issue Jun 2, 2025 that may be closed by this pull request

[Feature Request] Optimize new_worker_agent setting in Workforce #2470

Open

2 tasks

Wendong-Fan changed the title ~~Dynamic generate agent~~ feat: Dynamic generate agent Jun 2, 2025

Wendong-Fan added Agents Related to camel agents system New Feature Review Required PR need to be reviewed labels Jun 2, 2025

Wendong-Fan added this to Project Camel Jun 2, 2025

Wendong-Fan added this to the Sprint 30 milestone Jun 2, 2025

LIHUA919 approved these changes Jun 3, 2025

View reviewed changes

zjrwtx reviewed Jun 3, 2025

View reviewed changes

zjrwtx and others added 2 commits June 3, 2025 18:24

Merge branch 'master' into dynamic_generate_agent

4963550

Merge 4963550 into c0bbbff

2ef7dc2

Auto-update Mintlify documentation

3abc1df

fix: code format

bc4a47b

Wendong-Fan reviewed Jun 3, 2025

View reviewed changes

Merge remote-tracking branch 'origin/dynamic_generate_agent' into dyn…

506f47f

…amic_generate_agent

Yuujee added Waiting for Update PR has been reviewed, need to be updated based on review comment and removed Review Required PR need to be reviewed labels Jun 3, 2025

Yuujee added 2 commits June 3, 2025 23:28

code format

205e383

code format

b4b7955

Yuujee and others added 3 commits June 3, 2025 15:37

Merge b4b7955 into 1793418

a6ed6f7

Auto-update Mintlify documentation

9d9ca77

Merge branch 'master' into dynamic_generate_agent

2ec649d

	r"""
	Abstract base class for all tool selectors.
	r"""Abstract base class for all tool selectors.

feat: Dynamic generate agent #2540

Are you sure you want to change the base?

feat: Dynamic generate agent #2540

Uh oh!

Conversation

Yuujee commented Jun 2, 2025

Description

Checklist

Uh oh!

Yuujee commented Jun 2, 2025

Uh oh!

zjrwtx left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zjrwtx commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Yuujee commented Jun 3, 2025

Uh oh!

zjrwtx commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Wendong-Fan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot commented Jun 3, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

zjrwtx left a comment •

edited

Loading

zjrwtx commented Jun 3, 2025 •

edited

Loading

zjrwtx commented Jun 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)