Make control directive rely on control.setTarget #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elemoine
force-pushed
the
control-expression
branch
from
95bec5f to
cc317d4
Compare
elemoine
changed the title
|
This is now ready for review. With this the control directive relies on a control being made available in the parent scope, as opposed to a function that returned a control. Please review. |
|
It makes things simpler. I like it. |
|
And the problem was that the function was executed with |
elemoine
pushed a commit
that referenced
this pull request
Jan 16, 2015
Make control directive rely on control.setTarget
Yes, the user just needs to provide an expression that evaluates to a control (with no target and not already added to the map). |
elemoine
added a commit
to Geoportail-Luxembourg/geoportailv3
that referenced
this pull request
Jan 16, 2015
This is related to camptocamp/ngeo#143.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP depending on openlayers/openlayers#3139.