Skip to content

Conversation

@Buckwich
Copy link
Member

@Buckwich Buckwich commented Sep 8, 2025

Closes #5183

Proposed Changes

Enable editing of arrays of objects with an expandable table

image

Known Issues

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 8, 2025
@barmac barmac force-pushed the 5183_support-constraints branch 2 times, most recently from ffe82e7 to e8c1f76 Compare September 18, 2025 17:26
Base automatically changed from 5183_support-constraints to develop September 18, 2025 17:34
@Buckwich Buckwich force-pushed the 5183_add-expandable-table-settings-field branch 3 times, most recently from 0f77f27 to 08ec8d1 Compare September 29, 2025 10:12
@Buckwich Buckwich marked this pull request as ready for review September 29, 2025 10:24
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 29, 2025
@Buckwich Buckwich requested a review from Copilot September 29, 2025 10:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces an "expandable table" form field type that enables editing arrays of objects through an interactive table interface. Users can add, remove, and expand rows to edit nested properties within each array element.

Key changes:

  • Added expandable table field type with support for row and child properties
  • Implemented table UI with expand/collapse functionality for editing nested data
  • Added comprehensive test coverage for various scenarios including conditional fields and validation

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
resources/plugins/test-client/client/TestClient.js Adds example configuration for the new expandable table field type
client/src/plugins/settings/tests/SettingsFormSpec.js Comprehensive test suite covering expandable table functionality
client/src/plugins/settings/SettingsPlugin.less Styling for the expandable table component
client/src/plugins/settings/SettingsForm.js Core implementation of the expandable table field array component
client/src/app/Settings.js Updated type definitions to include the new expandable table type

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Buckwich Buckwich force-pushed the 5183_add-expandable-table-settings-field branch from 08ec8d1 to 8b4e18d Compare September 29, 2025 10:32
@Buckwich Buckwich requested review from a team, barmac and philippfromme and removed request for a team September 29, 2025 10:33
@Buckwich Buckwich marked this pull request as draft October 20, 2025 09:13
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Oct 20, 2025
@Buckwich Buckwich force-pushed the 5183_add-expandable-table-settings-field branch from 8b4e18d to dd8d866 Compare October 23, 2025 12:24
@Buckwich Buckwich marked this pull request as ready for review October 23, 2025 12:26
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 23, 2025
@Buckwich
Copy link
Member Author

rebased onto develop, main change is the add button is now icon first

@Buckwich Buckwich force-pushed the 5183_add-expandable-table-settings-field branch 2 times, most recently from 282c7e0 to 16817f3 Compare October 23, 2025 12:33
@Buckwich Buckwich changed the title feat: add expandable table settings form field Add expandable table settings form field Oct 27, 2025
@Buckwich Buckwich force-pushed the 5183_add-expandable-table-settings-field branch from 761d9ea to 3a221a4 Compare October 27, 2025 15:59
@Buckwich Buckwich force-pushed the 5183_add-expandable-table-settings-field branch from 3a221a4 to 41b6054 Compare November 13, 2025 14:33
@Buckwich
Copy link
Member Author

Marking draft as I think just reviewing #5375 is easier to review now in one go. But if you prefer to review this one just mark it ready again

@Buckwich Buckwich marked this pull request as draft November 14, 2025 09:21
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Nov 14, 2025
@Buckwich Buckwich changed the title Add expandable table settings form field [Reference] settings element: expandable table Nov 18, 2025
@Buckwich Buckwich removed the in progress Currently worked on label Nov 18, 2025
@Buckwich Buckwich added the backlog Queued in backlog label Nov 18, 2025
@Buckwich Buckwich removed their assignment Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backlog Queued in backlog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support more complex elements in settings

2 participants