-
Notifications
You must be signed in to change notification settings - Fork 520
[Reference] settings element: expandable table #5257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
ffe82e7 to
e8c1f76
Compare
0f77f27 to
08ec8d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces an "expandable table" form field type that enables editing arrays of objects through an interactive table interface. Users can add, remove, and expand rows to edit nested properties within each array element.
Key changes:
- Added expandable table field type with support for row and child properties
- Implemented table UI with expand/collapse functionality for editing nested data
- Added comprehensive test coverage for various scenarios including conditional fields and validation
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| resources/plugins/test-client/client/TestClient.js | Adds example configuration for the new expandable table field type |
| client/src/plugins/settings/tests/SettingsFormSpec.js | Comprehensive test suite covering expandable table functionality |
| client/src/plugins/settings/SettingsPlugin.less | Styling for the expandable table component |
| client/src/plugins/settings/SettingsForm.js | Core implementation of the expandable table field array component |
| client/src/app/Settings.js | Updated type definitions to include the new expandable table type |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
08ec8d1 to
8b4e18d
Compare
8b4e18d to
dd8d866
Compare
|
rebased onto develop, main change is the add button is now icon first |
282c7e0 to
16817f3
Compare
761d9ea to
3a221a4
Compare
3a221a4 to
41b6054
Compare
|
Marking draft as I think just reviewing #5375 is easier to review now in one go. But if you prefer to review this one just mark it ready again |
Closes #5183
Proposed Changes
Enable editing of arrays of objects with an expandable table
Known Issues
select allis not activated for the inputs: support Select All shortcut in settings fields #5306Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}