fix: add nosec annotations for bandit HIGH findings#5452
Open
louiseschmidtgen wants to merge 2 commits intomasterfrom
Open
fix: add nosec annotations for bandit HIGH findings#5452louiseschmidtgen wants to merge 2 commits intomasterfrom
louiseschmidtgen wants to merge 2 commits intomasterfrom
Conversation
Add inline nosec annotations for intentional security patterns flagged by bandit -lll (HIGH severity only). These are documented exceptions, not security vulnerabilities: - B501: verify=False used for internal cluster communication - B602: subprocess shell=True with trusted input
louiseschmidtgen
force-pushed
the
KU-5612/fix-bandit-findings
branch
from
1d3e390 to
9ec285e
Compare
There was a problem hiding this comment.
Pull request overview
Adds targeted inline # nosec annotations to suppress intentional Bandit HIGH findings introduced/flagged by the new SAST workflow, without changing runtime behavior.
Changes:
- Suppress Bandit B602 on a
subprocess.Popen(..., shell=True, ...)usage in cluster tests. - Suppress Bandit B501 on several
requests.post(..., verify=False, ...)calls in wrapper scripts.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/test-cluster.py |
Adds # nosec B602 on an LXC command execution path using shell=True. |
scripts/wrappers/upgrade.py |
Adds # nosec B501 for an internal HTTPS request with verify=False. |
scripts/wrappers/join.py |
Adds # nosec B501 on certificate-signing requests using verify=False. |
scripts/wrappers/distributed_op.py |
Adds # nosec B501 on distributed HTTPS operations using verify=False. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HomayoonAlimohammadi
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add inline
# nosecannotations for intentional security patterns flagged by the new bandit SAST workflow (-lll, HIGH severity only).These are all documented exceptions — not actual security vulnerabilities:
# nosec B501verify=Falseused for internal cluster communication# nosec B602subprocess(shell=True)with trusted/controlled input# nosec B324# nosec B701# nosec B202tarfile.extractallfrom trusted upstream release artifactsContext
Companion to the SAST workflows PR. Once both are merged, the bandit workflow will pass cleanly.