Skip to content

Conversation

@jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Aug 16, 2024

18 -> 22

@glenrobson
Copy link
Contributor

Should the docker compose files be called docker-compose.yml rather than compose.yaml for consistency?

@jcoyne
Copy link
Contributor Author

jcoyne commented Aug 27, 2024

@glenrobson I was migrating to the documented standard, which is compose.yaml https://docs.docker.com/compose/gettingstarted/#step-2-define-services-in-a-compose-file

@glenrobson
Copy link
Contributor

Thanks, I hadn't realised the recomended name had changed. I think there is still some insconsitency though:

  • docker/Linux-GraalVM20/docker-compose.yml
  • docker/Linux-JDK17/compose.yml
  • docker/Linux-JDK21/compose.yml
  • docker/Linux-JDK22/compose.yaml
  • docker/Windows-JDK11/docker-compose.yml
  • docker/Windows-JDK17/compose.yml
  • docker/Windows-JDK21/compose.yml
  • docker/Windows-JDK22/compose.yaml

@jcoyne
Copy link
Contributor Author

jcoyne commented Aug 27, 2024

@glenrobson fixed in #696. And JDK11 is EOL, so I'm not going to bother with that one. I'll make a pr to remove it once #693 is merged.

@jcoyne jcoyne force-pushed the jdk22 branch 3 times, most recently from 75c7277 to 04dbddd Compare August 28, 2024 15:47
@glenrobson glenrobson merged commit 2d8d974 into develop Sep 11, 2024
@glenrobson glenrobson deleted the jdk22 branch September 11, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants