ISSUE-724: Fixes access to frames other than 1 for Video #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size (and image info) for the first frame bc there is not such thing as variable frame size Video and also a Video could possible contain 60fps by the length images, which would basically lead to a info.json of HUGE sizes. By tapping into the getSize method and adding a helper function (isVideo) to the Info Class we avoid rewriting every v1/v2/v3 request for getSize(index) where a video could be involved. This seems cleaner
Makes sense to me to make it here so i can reuse the Video, itself. Will add another at the info Test class too
Contributor
Author
|
@glenrobson @jcoyne @ksclarke could any of you review my code style/sanity for this one? I feel it is a bit hack-ish so happy to address any concerns. All tests are passing now |
glenrobson
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #724
The way I approached is:
Added a few basic tests. Funny enough, our resource tests don't really use the Info class many times ... but I hope this covers it
FYI: this works